Skip to content

openfoam v1906 reorganized their wmake rules and now rely on General/…#1772

Merged
akesandgren merged 5 commits intoeasybuilders:developfrom
ComputeCanada:openfoam-v1906
Oct 10, 2019
Merged

openfoam v1906 reorganized their wmake rules and now rely on General/…#1772
akesandgren merged 5 commits intoeasybuilders:developfrom
ComputeCanada:openfoam-v1906

Conversation

@mboisson
Copy link
Copy Markdown
Contributor

…*/{c,c++} for compiler parameters

Comment thread easybuild/easyblocks/o/openfoam.py Outdated
Comment thread easybuild/easyblocks/o/openfoam.py Outdated
@boegel boegel added this to the 3.x milestone Aug 17, 2019
@boegel boegel added the update label Aug 17, 2019
boegel
boegel previously requested changes Aug 30, 2019
Comment thread easybuild/easyblocks/o/openfoam.py Outdated
@boegel boegel modified the milestones: 3.x, 4.x Aug 30, 2019
@akesandgren
Copy link
Copy Markdown
Contributor

@boegel are you satisified with the fix to your request? Then please handle it.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 22, 2019

@mboisson Blocked by conflicts with current develop...

@mboisson
Copy link
Copy Markdown
Contributor Author

@boegel it should be merged now.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @mboisson!

@akesandgren akesandgren merged commit d1ffb61 into easybuilders:develop Oct 10, 2019
@boegel boegel modified the milestones: 4.x, next release (4.0.1) Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants