fix compatibility of SuiteSparse easyblock with Python 3#1796
Merged
wpoely86 merged 1 commit intoeasybuilders:developfrom Aug 31, 2019
Merged
fix compatibility of SuiteSparse easyblock with Python 3#1796wpoely86 merged 1 commit intoeasybuilders:developfrom
wpoely86 merged 1 commit intoeasybuilders:developfrom
Conversation
wpoely86
approved these changes
Aug 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to force using a copy of
cfgvars.items()when iterating over it, because of thecfgvars.popbeing used in theforloop...This is only a problem with Python 3, where
.items()returns an iterator, while in Python 2 it's already a cope of keys & values in the dictionary (so changing the dictionary while iterating over it is not a problem there).(fixes #1784)