add support for installing Intel Inspector and VTune#180
add support for installing Intel Inspector and VTune#180boegel merged 2 commits intoeasybuilders:developfrom
Conversation
There was a problem hiding this comment.
I have noticed that all too often we prefer to hardwire INTEL_LICENSE_FILE and such variables inside the easyblocks - as opposed to easyconfigs; I'd say that i am at unease with that because I have spotted bugs across versions of the same package (eg. earlier icc versions have certain issues with the format of their license files) so, I'd say that preferring to tune them from the easyconfigs is more generic.
Other than that, it all looks good and it is ready to merge in!
There was a problem hiding this comment.
There's no hardcoding here.
The IntelBase easyblock has this:
self.license_file = self.cfg['license_file']It looks stupid, but there a reason it's like this (it used to be license for Intel tools, but that got overruled by the generic license easyconfig parameter, and we use the self.license_file to check deprecated use of license).
add support for installing Intel Inspector and VTune
No description provided.