Skip to content

don't load modules for dependencies in CrayToolchain.prepare_step#1805

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:craytc_fix
Sep 17, 2019
Merged

don't load modules for dependencies in CrayToolchain.prepare_step#1805
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:craytc_fix

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 16, 2019

requires easybuilders/easybuild-framework#3008

This should have been there all along, rather than relying on using dummy as a version for the dummy toolchain (which is deprecated in EasyBuild v4.0).

See also eth-cscs/production#1174 (review)

cc @victorusu, @gppezzi, @lucamar

@boegel boegel added the bug fix label Sep 16, 2019
@boegel boegel added this to the 4.0.0 milestone Sep 16, 2019
@boegel boegel mentioned this pull request Sep 16, 2019
Merged
@lucamar
Copy link
Copy Markdown

lucamar commented Sep 16, 2019

Thanks @boegel, this fix should make redundant the temporary workaround that I have used in craytoolchain.py, as reported by @victorusu in eth-cscs/production#1174 (namely, defining AVAIL_PRGENVS instead of KNOWN_PRGENVS). How can I test the fix? Do I need to bootstrap EasyBuild files from easybuilders:develop? With release 3.9.1 I get
TypeError: prepare_step() got an unexpected keyword argument 'load_tc_deps_modules'

@easybuilders easybuilders deleted a comment from boegelbot Sep 17, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 17, 2019

@lucamar To test, you would need to apply the changes made to easybuild/framework/easyblock.py from https://github.com/easybuilders/easybuild-framework/pull/3008/files#diff-a1bcbbc1aab6b59688b219f298fddb56 (which are fairly limited and backwards-compatible), and then download the updated craytoolchain.py and make EasyBuild use it via eb --include-easyblocks craytoolchain.py.

I tested it myself on Piz Daint, with this change (and the other fixes from https://github.com/easybuilders/easybuild-framework/pull/3008/files) I was able to install both CrayGNU/19.06 and HPL/2.3-CrayGNU-19.06 on top of it.

These fixes will be included in the upcoming EasyBuild v4.0; with EasyBuild v3.x you use the workaround of using dummy as toolchain version (but you'll still hit the problem with the faulty source being included in the output of modulecmd python load).

ocaisa
ocaisa approved these changes Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Cray to test it on, but the changes here are straightforward

@ocaisa ocaisa merged commit 2cad1a4 into easybuilders:develop Sep 17, 2019
@boegel boegel deleted the craytc_fix branch September 17, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @lucamar @ocaisa