Skip to content

176 bugfix matlab#181

Merged
boegel merged 10 commits intoeasybuilders:developfrom
fgeorgatos:176_bugfix_MATLAB
Apr 27, 2013
Merged

176 bugfix matlab#181
boegel merged 10 commits intoeasybuilders:developfrom
fgeorgatos:176_bugfix_MATLAB

Conversation

@fgeorgatos
Copy link
Copy Markdown
Contributor

@fgeorgatos fgeorgatos commented Apr 25, 2013

summary:

  • permit preinstallopts, installopts for generality and all-around-hackability
  • unhardwire _JAVA_OPTIONS definition
  • sanity_check_step & make_module_extra, to permit variations across MATLAB versions
  • remove spurious dependency on DISPLAY variable
  • cosmetic: rename license file to matlab.lic for conformity with other license business

@fgeorgatos fgeorgatos mentioned this pull request Apr 25, 2013
Closed
boegel
boegel reviewed Apr 25, 2013
View reviewed changes
Comment thread easybuild/easyblocks/m/matlab.py Outdated
Copy link
Copy Markdown
Member

@boegel boegel Apr 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the santiy_check_step definition here, it serves as a proper default MATLAB-custom sanity check.
Whenever sanity_check_paths is defined in the easyconfig file, that will take preference over whatever is here...

If you have useful additions to the MATLAB sanity check that are not system-specific, add them here.

Copy link
Copy Markdown
Contributor Author

@fgeorgatos fgeorgatos Apr 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever sanity_check_paths is defined in the easyconfig file, that will take preference

OK, that's a "feature" I ignored, good point then...

fgeorgatos
fgeorgatos reviewed Apr 26, 2013
View reviewed changes
Comment thread easybuild/easyblocks/m/matlab.py Outdated
Copy link
Copy Markdown
Contributor Author

@fgeorgatos fgeorgatos Apr 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be frank, I doubt a hardwired value here is a great idea, let alone that overriding it from easyconfig is mission impossible...

Copy link
Copy Markdown
Member

@boegel boegel Apr 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, so we should introduce a MATLAB-custom easyconfig parameter for this... PR coming up!

@boegel boegel mentioned this pull request Apr 26, 2013
Merged
fgeorgatos and others added 2 commits April 26, 2013 07:33
@fgeorgatos
Merge pull request #5 from boegel/176_bugfix_MATLAB
7741fe4 
avoid hardcoding Java option values + cosmetic changes
@fgeorgatos
adjust default _JAVA_OPTIONS to -Xmx256m
ca4bac6 
Signed-off-by: Fotis Georgatos <[email protected]>
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 27, 2013

OK, looks great now, and existing MATLAB easyconfigs are not broken. Merging in!

boegel added a commit that referenced this pull request Apr 27, 2013
@boegel
Merge pull request #181 from fgeorgatos/176_bugfix_MATLAB
acc8fad 
176 bugfix matlab
@boegel boegel merged commit acc8fad into easybuilders:develop Apr 27, 2013
@boegel boegel mentioned this pull request Apr 27, 2013
Closed
@fgeorgatos fgeorgatos deleted the 176_bugfix_MATLAB branch April 27, 2013 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

2 participants

@fgeorgatos @boegel