Add easyblock for installing MotionCor2.#1819
Merged
boegel merged 17 commits intoeasybuilders:developfrom Oct 8, 2019
Merged
Conversation
Also installs wrapper to load correct version of CUDA.
boegel
requested changes
Sep 28, 2019
houndci-bot
reviewed
Sep 29, 2019
boegel
requested changes
Sep 29, 2019
Member
|
@akesandgren I've fixed a similar issues in the tests in #1825 as you need here, should be fairly trivial to make the tests pass now here too if you take a look at that... |
Contributor
Author
|
You mean add stuff to test/easyblocks/module.py ... And something similar in test/easyblocks/init_easyblocks.py ?? |
Member
|
@akesandgren If you move what's now being done in |
houndci-bot
reviewed
Oct 7, 2019
…onCor2 easyblock.
Handle template_module_only_test running the MotionCor2 easyblock by checking for CUDA in prepare step and raise the error there.
houndci-bot
reviewed
Oct 7, 2019
boegel
reviewed
Oct 7, 2019
houndci-bot
reviewed
Oct 7, 2019
boegel
requested changes
Oct 8, 2019
Add docstrings
boegel
approved these changes
Oct 8, 2019
Member
|
Looks good, tested with easybuilders/easybuild-easyconfigs#8942, so good to go, thanks @akesandgren! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also installs wrapper to load correct version of CUDA.