Skip to content

fix for conda packages that rely on particular versions of Python#1836

Merged
boegel merged 2 commits intoeasybuilders:developfrom
jerowe:develop
Jan 14, 2020
Merged

fix for conda packages that rely on particular versions of Python#1836
boegel merged 2 commits intoeasybuilders:developfrom
jerowe:develop

Conversation

@jerowe
Copy link
Copy Markdown
Contributor

@jerowe jerowe commented Oct 22, 2019

Hi, @boegel!

I made a rather bone headed error when I was figuring out the logic for conda installs. There doesn't need to be two separate commands for first creating the conda env and then installing the requirement. It should be one, or else you run into errors.

An example error would be if you have a build dep of Miniconda3/4.7.10 along with the following easyconfig -

##
# This is an easyconfig file for EasyBuild, see https://github.com/easybuilders/easybuild
##

easyblock = 'Conda'

name = "hisat2"
version = "2.1.0"

homepage = 'https://bioconda.github.io/recipes/hisat2/README.html'
description = """graph-based alignment of next generation sequencing reads to a population of genomes"""

toolchain = SYSTEM

requirements = "%(name)s=%(version)s"
channels = ['bioconda', 'conda-forge']

builddependencies = [('Miniconda3', '4.7.10')]

sanity_check_paths = {
    'files': ['bin/python'],
    'dirs': ['bin']
}

moduleclass = 'tools'

Comment thread easybuild/easyblocks/generic/conda.py Outdated
@boegel boegel added this to the next release (4.1.0) milestone Nov 17, 2019
@boegel boegel added the bug fix label Nov 17, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2020

Let's see if I can wake up those tests with a close/re-open...

@boegel boegel closed this Jan 14, 2020
@boegel boegel reopened this Jan 14, 2020
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with QIIME2-2019.7.eb, thanks for the fix @jerowe!

@boegel boegel changed the title fix for conda packages that rely on particular versions of python fix for conda packages that rely on particular versions of Python Jan 14, 2020
@boegel boegel merged commit 483bc9f into easybuilders:develop Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants