A new easyblock for Scipion that handles version 2 and newer.#1847
Merged
smoors merged 9 commits intoeasybuilders:developfrom Jun 26, 2020
Merged
A new easyblock for Scipion that handles version 2 and newer.#1847smoors merged 9 commits intoeasybuilders:developfrom
smoors merged 9 commits intoeasybuilders:developfrom
Conversation
No support for older versions.
houndci-bot
reviewed
Nov 11, 2019
boegel
previously requested changes
Nov 15, 2019
Member
boegel
left a comment
There was a problem hiding this comment.
mostly tackled by akesandgren#10
fixes/cleanup in custom easyblock for Scipion
Contributor
Author
|
@boegel Anything else I should fix in this PR? |
Contributor
Author
|
Also, this superseedes #846 |
Contributor
Author
|
@boegel any more comments on this one?? |
smoors
previously requested changes
Apr 14, 2020
Suggestions incorporated
Contributor
|
closing-reopening |
Contributor
|
Going in, thanks @akesandgren! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No support for older versions.