Skip to content

add easyblock for ELSI#1883

Merged
akesandgren merged 7 commits intoeasybuilders:developfrom
migueldiascosta:elsi
Feb 14, 2020
Merged

add easyblock for ELSI#1883
akesandgren merged 7 commits intoeasybuilders:developfrom
migueldiascosta:elsi

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

there are more libraries besides ELPA that can be specified as external instead of built, and other optional libraries, see "Solver Libraries and External Dependencies" in https://wordpress.elsi-interchange.org/index.php/download/, not sure if there is demand for those

Motivation was its use in the new "MaX release version" of SIESTA (PR coming soon)

boegel
boegel previously requested changes Dec 13, 2019
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
@boegel boegel added this to the 4.x milestone Dec 13, 2019
Comment thread easybuild/easyblocks/e/elsi.py
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
Comment thread easybuild/easyblocks/e/elsi.py Outdated
akesandgren
akesandgren previously approved these changes Feb 14, 2020
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migueldiascosta migueldiascosta changed the title add easyblock for ELSI (WIP) add easyblock for ELSI Feb 14, 2020
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren dismissed boegel’s stale review February 14, 2020 11:43

Code changed in a different way.

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @migueldiascosta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants