also copy component patches to self.cfg in Bundle generic easyblock#1897
Merged
pescobar merged 1 commit intoeasybuilders:developfrom Dec 24, 2019
Merged
also copy component patches to self.cfg in Bundle generic easyblock#1897pescobar merged 1 commit intoeasybuilders:developfrom
pescobar merged 1 commit intoeasybuilders:developfrom
Conversation
2 tasks
boegel
added a commit
to Flamefire/easybuild-easyconfigs
that referenced
this pull request
Dec 24, 2019
…a256_checksums in easyconfigs tests (cfr. easybuilders/easybuild-easyblocks#1897)
Flamefire
reviewed
Dec 24, 2019
|
|
||
| # reset list of sources/source_urls/checksums | ||
| comp_cfg['sources'] = comp_cfg['source_urls'] = comp_cfg['checksums'] = [] | ||
| comp_cfg['sources'] = comp_cfg['source_urls'] = comp_cfg['checksums'] = comp_cfg['patches'] = [] |
Contributor
There was a problem hiding this comment.
This is a serious bug. It sets all of them to the same list! So if you do comp_cfg['sources'].append('foo') it will also append it to the others unless some copy trickery is done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1893
This doesn't affect the way in which a bundle of components is installed, but it's important for the checksum check we do in the easyconfigs test suite (see #1893)...