Skip to content

iccifort: remove LIBRARY_PATH entries already known to icc et al#1904

Merged
boegel merged 3 commits intoeasybuilders:developfrom
ComputeCanada:icc-no-library-cpath
Jan 6, 2020
Merged

iccifort: remove LIBRARY_PATH entries already known to icc et al#1904
boegel merged 3 commits intoeasybuilders:developfrom
ComputeCanada:icc-no-library-cpath

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman commented Jan 4, 2020

This makes it consistent with Intel's own script that don't set
LIBRARY_PATH either (except for aux components such as TBB)

But only do this for iccifort (single installation) so that in a split
installation icc can still find ifort's libraries and vice versa.

@bartoldeman
iccifort: remove LIBRARY_PATH entries already known to icc et al
83bf4d7 
This makes it consistent with Intel's own script that don't set
LIBRARY_PATH either (except for aux components such as TBB)

But only do this for iccifort (single installation) so that in a split
installation icc can still find ifort's libraries and vice versa.
houndci-bot
houndci-bot reviewed Jan 4, 2020
View reviewed changes
Comment thread easybuild/easyblocks/i/iccifort.py Outdated
@boegel boegel added the change label Jan 5, 2020
@boegel boegel added this to the 4.x milestone Jan 5, 2020
@boegel boegel added the bug fix label Jan 5, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 6, 2020

Tested with standalone iccifort that is part of intel/2019b and intel/2020.00 + a couple of installation using that iccifort as toolchain, no problems encountered, so good to go in...

Thanks @bartoldeman!

@boegel boegel modified the milestones: 4.x, next release (4.1.1) Jan 6, 2020
@boegel boegel merged commit f36183f into easybuilders:develop Jan 6, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 14, 2020

@bartoldeman I think this broke something after all...

The installation of BLAST+-2.9.0-iimpi-2019b.eb is failing for me when the iccifort module is not including the compiler/lib/intel64 subdirectory in $LIBRARY_PATH with:

ld.gold: error: cannot find -liomp5

The problem doesn't occur when the compiler/lib/intel64 path is still being added to $LIBRARY_PATH by the iccifort module...

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 14, 2020

After taking a closer look, I noticed the failing link command is using gcc rather than the expected icc or mpiicc, so I guess that's the real problem with building BLAST+ with iimpi/2019b, and this change just exposes that problem better...

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 16, 2020

To avoid a "wisdom of the ancients" situation: gcc was only used to build a small helper utility during the build of BLAST+, and $LIBS (containing -liomp5) was being picked up, which led to the reported cannot find -liomp5` error.

Fixed by unsetting $LIBS, see easybuilders/easybuild-easyconfigs@4c40033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoldeman @boegel @houndci-bot