update Trinity easyblock for v2.9.0#1906
Merged
boegel merged 8 commits intoeasybuilders:developfrom Mar 1, 2020
Merged
Conversation
Contributor
manifestoso
commented
Jan 6, 2020
- trinity butterfly .jar provided in v2.9.0
- sanity checks updates
houndci-bot
reviewed
Jan 6, 2020
houndci-bot
reviewed
Jan 6, 2020
boegel
requested changes
Jan 12, 2020
Member
boegel
left a comment
There was a problem hiding this comment.
@robqiao Since you're using tab characters rather than spaces, the automated code style check performed by the Hound CI bot fails, please try fixing these issues (and let us know if you need help with it).
houndci-bot
reviewed
Jan 13, 2020
Contributor
Author
Style seems now fixed ✔️ . Thx @boegel. |
manifestoso
commented
Jan 13, 2020
Contributor
Author
manifestoso
left a comment
There was a problem hiding this comment.
trailing space fix
boegel
requested changes
Jan 13, 2020
manifestoso
commented
Jan 16, 2020
boegel
approved these changes
Mar 1, 2020
Member
boegel
left a comment
There was a problem hiding this comment.
lgtm, tested with all existing Trinity easyconfigs + easybuilders/easybuild-easyconfigs#9559, so good to go
Thanks a lot for your efforts on this @robqiao!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.