add custom easyconfig parameter 'buildtype' to generic CMakeMake easyblock#1915
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jan 14, 2020
Merged
Conversation
houndci-bot
reviewed
Jan 13, 2020
Heavily based on code from Ward Poelmans
7c9ff3a to
ddd3f43
Compare
Contributor
Author
|
@wpoely86 Hope you don't mind me taking this, I added your name to the commit message I also made it more minimal and simpler |
Member
|
No problem! |
Contributor
Author
|
Follow-up: Replace and validate all usages of CMAKE_BUILD_TYPE in EBs, I've seen "release" and "RELEASE" which is likely wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heavily based on code from Ward Poelmans from #911
IMO setting the buildtype is valuable to not have to work with the quite verbose configopts.
Note that configopts is passed AFTER this option so it can still override CMAKE_BUILD_TYPE and that there is NO change to the default behavior: Nothing is added unless buildtype is set
note: renamed to
build_typein #1922