Skip to content

[HDF5] Fix 'in' vs '==' confusion#1919

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:hdf5_mpicxx
Jan 14, 2020
Merged

[HDF5] Fix 'in' vs '==' confusion#1919
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:hdf5_mpicxx

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Followup to #1918

But not critical as both versions seem to work fine

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2020

The in only works by accident (because toolchain.OPENMPI is a string value), but we should really use ==.

@boegel boegel merged commit c17d2fb into easybuilders:develop Jan 14, 2020
@Flamefire Flamefire deleted the hdf5_mpicxx branch January 14, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants