Skip to content

get_tbb_gccprefix: support GCCcore and gcc4.8 (if that dir exists)#1943

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
ComputeCanada:fix-tbb-library-path
Feb 13, 2020
Merged

get_tbb_gccprefix: support GCCcore and gcc4.8 (if that dir exists)#1943
akesandgren merged 1 commit intoeasybuilders:developfrom
ComputeCanada:fix-tbb-library-path

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

This fixes the issue that icc/iccifort/recent tbb installations may no longer set LD_LIBRARY_PATH and LIBRARY_PATH, since the library files may now be in a gcc4.8 subdirectory.

This fix is as minimal as possible, though I doubt that gcc<4.4 is relevant any more.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren added this to the next release (4.1.2?) milestone Feb 13, 2020
@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @bartoldeman!

@akesandgren akesandgren merged commit 3281c86 into easybuilders:develop Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants