openblas: add optional runtest to the catch for FATAL ERRORS#1958
Merged
akesandgren merged 1 commit intoeasybuilders:developfrom Feb 13, 2020
Merged
openblas: add optional runtest to the catch for FATAL ERRORS#1958akesandgren merged 1 commit intoeasybuilders:developfrom
akesandgren merged 1 commit intoeasybuilders:developfrom
Conversation
Contributor
|
Going in, thanks @lexming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional tests added with the
runtestoption were left out from the catch ofFATAL ERRORS. However, tests such asblas-testcan behave in a similar way as the defaultmake tests, revealing build errors that are going unnoticed by EB.This PR fixes this issue by parsing all test outputs and raising an error if
FATAL ERRORis found in any of them.