Skip to content

reinstate parallel building of OpenBLAS#1962

Merged
lexming merged 3 commits intoeasybuilders:developfrom
boegel:openblas_make_j
Feb 13, 2020
Merged

reinstate parallel building of OpenBLAS#1962
lexming merged 3 commits intoeasybuilders:developfrom
boegel:openblas_make_j

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 13, 2020

(was accidentally disabled in #1952)

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be beneficial parallelize the test_step as well?

Comment thread easybuild/easyblocks/o/openblas.py Outdated
Comment thread easybuild/easyblocks/o/openblas.py Outdated
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 13, 2020

I reply my own question. The test step is not parallelized in configuremake, so we will do the same for openblas.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 13, 2020

Tested with OpenBLAS-0.3.7-GCC-8.3.0.eb and OpenBLAS-0.3.8-GCC-9.2.0.eb from develop and it is working as intended.

LGTM

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

@lexming You need to approve the " " change so we can merge this.

@lexming lexming merged commit 1ce9414 into easybuilders:develop Feb 13, 2020
@boegel boegel deleted the openblas_make_j branch February 13, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants