fix netCDF support in Siesta easyblock#1967
Merged
smoors merged 1 commit intoeasybuilders:developfrom Feb 20, 2020
Merged
Conversation
Contributor
|
@migueldiascosta could you generate a test report for easybuilders/easybuild-easyconfigs#9858 with this fix applied? |
Member
Author
Member
|
Hmm, did this break I'm getting this now: |
Member
Author
|
bummer... will look into it |
Member
Author
|
the include flag for netcdf is not being picked up when building siesta's ncdf module, this fixes it --- siesta.py.orig 2020-02-21 12:58:08.255020893 +0800
+++ siesta.py 2020-02-21 14:32:21.233017759 +0800
@@ -181,6 +181,7 @@
(r"^(COMP_LIBS\s*=.*)$", r"\1 libncdf.a libfdict.a"),
])
netcdf_lib_and_inc = "NETCDF_LIBS = -lnetcdff\nNETCDF_INCLUDE = -I%s/include" % netcdff_loc
+ netcdf_lib_and_inc += "\nINCFLAGS = $(NETCDF_INCLUDE)"
regex_newlines.append((r"^(COMP_LIBS\s*=.*)$", r"\1\n%s" % netcdf_lib_and_inc))
xmlf90 = get_software_root('xmlf90')but I don't know why it is only needed with foss and not with intel... |
migueldiascosta
added a commit
to migueldiascosta/easybuild-easyblocks
that referenced
this pull request
Feb 21, 2020
Member
|
@migueldiascosta Could be a difference between Can you open a pull request for that fix? |
Member
|
Ah, already there in #1971, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)fixes #1965