Skip to content

add custom easyblock for FreeFEM#1969

Merged
lexming merged 8 commits intoeasybuilders:developfrom
boegel:freefem
Jun 5, 2021
Merged

add custom easyblock for FreeFEM#1969
lexming merged 8 commits intoeasybuilders:developfrom
boegel:freefem

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 20, 2020

This is an updated version of #1488.

@boegel boegel added the new label Feb 20, 2020
@boegel boegel added this to the 4.x milestone Feb 20, 2020
Comment thread easybuild/easyblocks/f/freefem.py Outdated
Comment thread easybuild/easyblocks/f/freefem.py Outdated
Comment thread easybuild/easyblocks/f/freefem.py Outdated
Comment thread easybuild/easyblocks/f/freefem.py Outdated
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 21, 2020

@boegel is there a difference in performance between setting
OPENBLAS_NUM_THREAD or OMP_NUM_THREADS to 1?

Comment thread easybuild/easyblocks/f/freefem.py Outdated
except ValueError as err:
raise EasyBuildError("Failed to parse 'parallel' value '%s' as integer: %s", parallel, err)

# use number of threads equal to 1/4th of available cores (and ensure at least one)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel this is quite conservative?

Comment thread easybuild/easyblocks/f/freefem.py Outdated
# run tests unless they're disabled explicitly
if self.cfg['runtest'] is None or self.cfg['runtest']:
# avoid oversubscribing, by using both OpenMP threads and having OpenBLAS use threads as well
env.setvar('OPENBLAS_NUM_THREAD', '1')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I think this should be OPENBLAS_NUM_THREADS ? (added 'S')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, needs the 'S'

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 21, 2020

@boegel also, according to the OpenBLAS documentation https://github.com/xianyi/OpenBLAS
'OpenBLAS ignores OPENBLAS_NUM_THREADS and GOTO_NUM_THREADS when compiled with USE_OPENMP=1.'
so, IIUC, this means that setting OPENBLAS_NUM_THREADS does not do anything?
(since USE_OPENMP=1 in the openblas easyblock)

@akesandgren
Copy link
Copy Markdown
Contributor

Precisely, one should use OMP_NUM_THREAD and nothing else.

Comment thread easybuild/easyblocks/f/freefem.py Outdated
Comment thread easybuild/easyblocks/f/freefem.py
Comment thread easybuild/easyblocks/f/freefem.py Outdated
Comment thread easybuild/easyblocks/f/freefem.py Outdated
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 4, 2021

@lexming Suggestions (finally!) tackled, can you take another look?

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 5, 2021

@lexming lexming modified the milestones: 4.x, next release (4.4.1) Jun 5, 2021
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 5, 2021

Going in, thanks for the update @boegel !

@lexming lexming merged commit 05a4c2f into easybuilders:develop Jun 5, 2021
@boegel boegel deleted the freefem branch June 5, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants