add more configure option for dependencies in Score-P easyblock#2030
Merged
boegel merged 1 commit intoeasybuilders:developfrom Apr 18, 2020
Merged
add more configure option for dependencies in Score-P easyblock#2030boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
boegel
approved these changes
Apr 18, 2020
Member
boegel
left a comment
There was a problem hiding this comment.
reviewed and re-tested with existing Score-P easyconfigs, lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configure actually detects all those just fine, so these changes are not required. However it makes it safer as those values are preferred (not taken as-is) so it doesn't accidentally pick up a system or user version.
Additionally it adds
--enable-cudawhich I expect to produce a configure failure if it is not found.Tested in easybuilders/easybuild-easyconfigs#10397