Skip to content

fix typo in LAMMPS easyblock preventing disabling the USER-INTEL package via configopts#2031

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:fix-lammps-typo
Apr 16, 2020
Merged

fix typo in LAMMPS easyblock preventing disabling the USER-INTEL package via configopts#2031
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:fix-lammps-typo

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 16, 2020

(created using eb --new-pr)

@boegel boegel added the bug fix label Apr 16, 2020
@boegel boegel added this to the next release (4.2.1?) milestone Apr 16, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 16, 2020

Users have reported correctness issues for LAMMPS installations that were built with -DPKG_USER-INTEL=on, and I bumped into this typo when trying to disable the USER-INTEL package via configopts in the easyconfig file...

ocaisa
ocaisa previously approved these changes Apr 16, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 16, 2020

@ocaisa Don't merge this yet, I'm working on additional changes to prevent more silly typos like this.

Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 16, 2020

relevant easyconfigs PR: easybuilders/easybuild-easyconfigs#10418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants