Skip to content

update ABAQUS easyblock to support installation of v2020#2034

Merged
boegel merged 14 commits intoeasybuilders:developfrom
bear-rsg:abaqus
Aug 27, 2021
Merged

update ABAQUS easyblock to support installation of v2020#2034
boegel merged 14 commits intoeasybuilders:developfrom
bear-rsg:abaqus

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Apr 16, 2020 •
edited
Loading

There are some differences to where some items end up being installed. The items that were in sim are now in cae and I could not see a way to separate them from the items that are installed into cae. (This is compared to an ABAQUS 2017 installation - we do not have a newer version installed.)

@branfosj branfosj mentioned this pull request Apr 16, 2020
Merged
@boegel boegel added the update label Apr 17, 2020
@boegel boegel added this to the 4.x milestone Apr 17, 2020
@boegel boegel changed the title ABAQUS 2020 updates update ABAQUS easyblock to support installation of v2020 Apr 17, 2020
smoors
smoors reviewed Apr 18, 2020
View reviewed changes
Comment thread easybuild/easyblocks/a/abaqus.py Outdated
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Apr 20, 2020

I've uploaded https://gist.github.com/branfosj/f0bfa2410f7279e5c2d0dfb58bc3c2e6 which is the output of the ABAQUS installer for one of my test runs. This means that we have a record of the path through the installer.

@boegel boegel modified the milestones: 4.x, next release (4.2.2?) May 24, 2020
boegel
boegel requested changes May 25, 2020
View reviewed changes
Comment thread easybuild/easyblocks/a/abaqus.py Outdated
Comment thread easybuild/easyblocks/a/abaqus.py Outdated
@branfosj branfosj marked this pull request as draft May 31, 2020 07:48
@branfosj branfosj marked this pull request as ready for review May 31, 2020 09:48
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 31, 2020 •
edited
Loading

Test report using the latest version of the block is at easybuilders/easybuild-easyconfigs#10423 (comment)

I've also tested this with ABAQUS 2017 and that installs fine. I've not got the sources for 2018 or 2019 so I cannot test those.

@branfosj branfosj requested a review from boegel May 31, 2020 10:53
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 2, 2020

close/re-open to refresh CI (we now have a stricter code style check)

@boegel boegel closed this Sep 2, 2020
@boegel boegel reopened this Sep 2, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 8, 2020

@branfosj This breaks the installation of ABAQUS-2018-hotfix-1806.eb:

It looks like it chokes on this now, not being able to answer this question:

_______________________________________________________________________________

   SIMULIA fe-safe 2018 fe-safe
_______________________________________________________________________________

Choose the installation directory:
Input !c to clear the default value. Input !q and hit Enter to quit. Just press Enter to continue.                                                                                                                                                                                                                                                                                                                                                                                                                                                              
Default [/usr/SIMULIA/fe-safe/2018]:

boegel
boegel reviewed Sep 8, 2020
View reviewed changes
Comment thread easybuild/easyblocks/a/abaqus.py Outdated
r"Please choose an action:": '1',

# Continue
nextstr: '',
Copy link
Copy Markdown
Member

@boegel boegel Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj One thing to be aware of here is that there's no order over these patterns (because it's a dict value).

So if the pattern in nextstr is matched, you won't match any other more specific patterns that also include the nextstr pattern...

@boegel boegel modified the milestones: 4.3.1 (next release), 4.3.2 Oct 25, 2020
@boegel boegel modified the milestones: 4.3.2 (next release), 4.4.0 Dec 8, 2020
@mboisson
Copy link
Copy Markdown
Contributor

mboisson commented Feb 23, 2021

What is the status of this PR ?

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 23, 2021

What is the status of this PR ?

It works for me for both ABAQUS 2017 and 2020 (these are the versions I have sources for). However, it is broken installing ABAQUS 2018 hotfix 1806 (and maybe other versions). The broken installs may be because of the issue in #2034 (comment)

Currently I do not have the time to investigate further.

@boegel boegel modified the milestones: 4.4.0, release after 4.4.0 May 26, 2021
boegel
boegel requested changes Aug 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj I think we need to switch to using an ordered dictionary to ensure that the question patterns are considered in order.
I did that in bear-rsg#91, and it fixes the issue where the installation of older ABAQUS got broken...

@branfosj
Merge pull request #91 from boegel/abaqus
8ab63d4 
use OrderedDict to std_qa in ABAQUS easyblock
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 27, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS ABAQUS-2017-hotfix-1721.eb
  • SUCCESS ABAQUS-2018-hotfix-1806.eb
  • SUCCESS ABAQUS-6.12.1-linux-x86_64.eb
  • SUCCESS ABAQUS-6.13.5-linux-x86_64.eb
  • SUCCESS ABAQUS-6.14.1-linux-x86_64.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node2723.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/f586013032a4baf22ca64489d03fe8ee for a full test report.

@boegel boegel merged commit ee5a5df into easybuilders:develop Aug 27, 2021
@branfosj branfosj deleted the abaqus branch August 27, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors left review comments

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegel @mboisson @smoors