Skip to content

Fix minor bug in shared libs handling and correctly setup SuiteSparse variables in Trilinos easyblock#2071

Merged
Micket merged 2 commits intoeasybuilders:developfrom
akesandgren:20200529181801_new_pr_UZYqYPTlda
Jun 2, 2020
Merged

Fix minor bug in shared libs handling and correctly setup SuiteSparse variables in Trilinos easyblock#2071
Micket merged 2 commits intoeasybuilders:developfrom
akesandgren:20200529181801_new_pr_UZYqYPTlda

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@akesandgren akesandgren changed the title Fix minor bug in shared libs handling and correctly setup SuiteSparse variables trilinos.py: Fix minor bug in shared libs handling and correctly setup SuiteSparse variables May 29, 2020
Micket
Micket previously approved these changes May 29, 2020
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the next release (4.2.2?) milestone May 29, 2020
@akesandgren akesandgren changed the title trilinos.py: Fix minor bug in shared libs handling and correctly setup SuiteSparse variables trilinos.py: Fix minor bug in shared libs handling and correctly setup SuiteSparse variables (WIP) Jun 1, 2020
@akesandgren akesandgren changed the title trilinos.py: Fix minor bug in shared libs handling and correctly setup SuiteSparse variables (WIP) trilinos.py: Fix minor bug in shared libs handling and correctly setup SuiteSparse variables Jun 1, 2020
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 2, 2020

@Micket Micket merged commit c493982 into easybuilders:develop Jun 2, 2020
@akesandgren akesandgren deleted the 20200529181801_new_pr_UZYqYPTlda branch June 3, 2020 05:37
@boegel boegel changed the title trilinos.py: Fix minor bug in shared libs handling and correctly setup SuiteSparse variables Fix minor bug in shared libs handling and correctly setup SuiteSparse variables in Trilinos easyblock Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants