don't require include-fixed subdirectory in GCC installation for building TensorFlow, only use it when it's there#2093
Merged
lexming merged 1 commit intoeasybuilders:developfrom Jul 7, 2020
Conversation
…ding TensorFlow, only use it when it's there (partial fix for easybuilders#2092)
Member
Author
|
Confirmed fix for |
wpoely86
reviewed
Jul 7, 2020
| if os.path.exists(gcc_cplusplus_inc): | ||
| inc_paths.append(gcc_cplusplus_inc) | ||
| else: | ||
| raise EasyBuildError("Derived directory %s does not exist", gcc_cplusplus_inc) |
Member
There was a problem hiding this comment.
because it's just a info message, here it's fatal?
Member
Author
There was a problem hiding this comment.
It was fatal before, I don't see a reason to change it?
We now know that include-fixed may not be there, and that it's acceptable. It's not acceptable for this path though, so if it's not there, we want to know about it (in case the path changes or something in newer GCC versions).
Contributor
|
Positive test with Positive test with |
Contributor
|
Going in, thanks @boegel ! |
boegel
added a commit
to boegel/easybuild-easyblocks
that referenced
this pull request
Jul 7, 2020
…elease notes
This was referenced Jul 7, 2020
Closed
migueldiascosta
added a commit
to migueldiascosta/easybuild-easyblocks
that referenced
this pull request
Jul 8, 2020
add PRs easybuilders#2093 and easybuilders#2094 to EasyBuild v4.2.2 release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(partial fix for #2092)