check for installation of pip & setuptools in Python 3.4+#2108
Merged
ocaisa merged 5 commits intoeasybuilders:developfrom Sep 1, 2020
Merged
check for installation of pip & setuptools in Python 3.4+#2108ocaisa merged 5 commits intoeasybuilders:developfrom
ocaisa merged 5 commits intoeasybuilders:developfrom
Conversation
See easybuilders/easybuild-easyconfigs#11009 for how this fails
ocaisa
requested changes
Jul 28, 2020
Member
ocaisa
left a comment
There was a problem hiding this comment.
Still have to take this for a test drive
lexming
reviewed
Aug 5, 2020
Co-authored-by: Alex Domingo <[email protected]>
Contributor
Author
ocaisa
approved these changes
Sep 1, 2020
Member
ocaisa
left a comment
There was a problem hiding this comment.
Just waiting on the install to finish to confirm the additional sanity checks are used
Member
|
Going in, thanks @Flamefire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.4 comes with pip and setuptools. This is even required to install (the newer) pip in the EC so not having it is an error.
Furthermore installation of pip/setuptools fails if a distutils user config sets the
prefixto a different directory as that would be where pip is then installed. See easybuilders/easybuild-easyconfigs#11009Hence check for that and report a (verbose) warning.