make TensorFlow easyblock also set $GCC_HOST_COMPILER_PREFIX to specify binutils location#2110
Merged
boegel merged 1 commit intoeasybuilders:developfrom Aug 4, 2020
Merged
Conversation
This avoids the need for the patch removing -B/usr/bin as TF will add GCC_HOST_COMPILER_PREFIX instead which is the correct path Also some simplification of the used lists
Merged
2 tasks
Member
|
I've tested this with various existing TensorFlow easyconfigs, both with the |
boegel
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the need for the patch removing -B/usr/bin as TF will add GCC_HOST_COMPILER_PREFIX instead which is the correct path
Also some simplification of the used lists
This is required to be able to install TF 2.3.0: tensorflow/tensorflow#41856 and allows to remove the patch from previous TF ECs (TODO: Do this after this is merged)