Skip to content

Add custom easyblock for pybind11#2115

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
Flamefire:pybind11
Aug 14, 2020
Merged

Add custom easyblock for pybind11#2115
migueldiascosta merged 1 commit intoeasybuilders:developfrom
Flamefire:pybind11

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

This makes sure that the installed Pybind11 can be found by pip in addition to CMake which avoids a redownload by e.g. SciPy

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 11, 2020

why not just install it with pip and add a postinstallcmds with a symbolic link from site-packages/pybind11/include to %(installdir)s/include?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Because then it would be missing the CMake config files we currently have. Also the location of the headers vary. For <2.5 they are at installdir/include/python3.7m and for 2.5 they are in site-packages

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @Flamefire!

@migueldiascosta migueldiascosta merged commit 358f8e4 into easybuilders:develop Aug 14, 2020
@Flamefire Flamefire deleted the pybind11 branch August 14, 2020 07:09
@boegel boegel changed the title Add EasyBlock for Pybind11 Add custom easyblock for pybind11 Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants