take existing 'lib' subdir into account when copying it to test GROMACS installation#2154
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Sep 2, 2020
Merged
Conversation
7838ffa to
86d80ec
Compare
ocaisa
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)The changes made in #2144 don't take into account that there may already exist a
libsubdirectory in the installation directory, since GROMACS is an iterated installation.I missed this initially because this is not a problem on CentOS (where the GROMACS libraries are installed in
lib64, while the Python stuff goes intolib), but it is an issue on Debian which favorsliboverlib64, which leads to an error like: