update TensorFlow easyblock to support installing TensorFlow 2.0 with dependencies provided through EasyBuild#2165
Merged
boegel merged 3 commits intoeasybuilders:developfrom Sep 9, 2020
Conversation
1 task
boegel
approved these changes
Sep 9, 2020
Member
boegel
left a comment
There was a problem hiding this comment.
lgtm, will test it too before merging
Member
|
tested with easybuilders/easybuild-easyconfigs#11233, good to go, thanks @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds $TF_SYSTEM_LIBS for TF 2.0 (verified with 2.0.0/fosscuda) and improves the logs. Most notably it mentions "$TF_SYSTEM_LIBS" so the log can be searched for that. I also slightly clarified the meaning of the dependency lists
As can be verified by reviewing the changes only TF 2.0 ECs are affected by this change so others don't need to be tested
This should be tested with easybuilders/easybuild-easyconfigs#11233