improve workaround for JsonCpp dependency in TensorFlow easyblock#2172
Merged
boegel merged 1 commit intoeasybuilders:developfrom Sep 11, 2020
Merged
Conversation
The TensorFlow sources include the json sources as "include/json/..." which is unusual As a workaround the root folder to JsonCpp is added to CPATH. However for fixed versions this is not required and the include folder should be added instead. A patch for 2.3 exists and will be part of all future releases. 2.3+ ECs should hence rather use the patch instead. To avoid having to change existing ECs not using the patch but allow them to use the patch both folders are added.
boegel
approved these changes
Sep 11, 2020
Member
boegel
left a comment
There was a problem hiding this comment.
lgtm, tested with a variety of TensorFlow easyconfigs...
boegel
added a commit
to migueldiascosta/easybuild-easyblocks
that referenced
this pull request
Sep 11, 2020
…e date to Sept 13th
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TensorFlow sources include the json sources as "include/json/..." which is unusual
As a workaround the root folder to JsonCpp is added to CPATH.
However for fixed versions this is not required and the include folder should be added instead.
A patch for 2.3 exists and will be part of all future releases. 2.3+ ECs should hence rather use the patch instead.
To avoid having to change existing ECs not using the patch but allow them to use the patch both folders are added.