Skip to content

updated CBLAS easyblock for toolchains that include imkl#2175

Merged
boegel merged 6 commits intoeasybuilders:developfrom
Darkless012:update_cblas_easyblock
Sep 17, 2020
Merged

updated CBLAS easyblock for toolchains that include imkl#2175
boegel merged 6 commits intoeasybuilders:developfrom
Darkless012:update_cblas_easyblock

Conversation

@Darkless012
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread easybuild/easyblocks/c/cblas.py Outdated
@boegel boegel added this to the next release (4.3.1) milestone Sep 14, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2020

@Darkless012 Also needs a sync with develop, it seems like you forked your branch from an outdated develop branch?

We've done some code style cleanup recently (see https://github.com/easybuilders/easybuild-easyblocks/pull/2129/files#diff-701f48385de9e1dfd0c15d2874629964), so the conflict should be trivial to resolve...

@Darkless012 Darkless012 force-pushed the update_cblas_easyblock branch from ef92cac to 47b99fc Compare September 15, 2020 09:13
Comment thread easybuild/easyblocks/c/cblas.py Outdated
@boegel boegel changed the title updated cblas easyblock for new toolchains updated CBLAS easyblock for toolchains that include imkl Sep 15, 2020
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tested with existing CBLAS-20110120-foss-2016b.eb + the easyconfigs using a recent intel toolchain from easybuilders/easybuild-easyconfigs#11265, works like a charm! 👍

@boegel boegel merged commit 587e432 into easybuilders:develop Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants