Skip to content

Workaround duplicate prefix path in Eigen CMake config#2176

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
Flamefire:fix_eigen_include
Sep 24, 2020
Merged

Workaround duplicate prefix path in Eigen CMake config#2176
akesandgren merged 1 commit intoeasybuilders:developfrom
Flamefire:fix_eigen_include

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

The current EasyBlock causes a duplicate (install) prefix paths in the CMake files leading to /foo/Eigen/foo/Eigen/include as the paths causing dependencies to choke on that, also mostly minor as we have the full/correct path in CPATH

See https://gitlab.com/libeigen/eigen/-/issues/1990

The current EasyBlock causes a duplicate (install) prefix paths in the CMake files leading to /foo/Eigen/foo/Eigen/include
as the paths causing dependencies to choke on that, also mostly minor as we have the full/correct path in CPATH
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @Flamefire!

@akesandgren akesandgren merged commit 6423884 into easybuilders:develop Sep 24, 2020
@Flamefire Flamefire deleted the fix_eigen_include branch September 24, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants