Enable CTEST_OUTPUT_ON_FAILURE for CMakeMake test_step#2181
Merged
akesandgren merged 1 commit intoeasybuilders:developfrom Sep 23, 2020
Merged
Enable CTEST_OUTPUT_ON_FAILURE for CMakeMake test_step#2181akesandgren merged 1 commit intoeasybuilders:developfrom
akesandgren merged 1 commit intoeasybuilders:developfrom
Conversation
Contributor
|
And your ideas regarding testing looks sane. The problem with runtest only is that it might be overridden. |
Contributor
|
Going in, thanks @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to see the output of failing tests which might help finding the issue
While being at it: I'd like to provide an easy/easier way to run tests when building with CMake. It really bothers me that we don't test by default with configuremake based ECs (including meson, cmake, ...)
When using CMake the default setting to use is
-DBUILD_TESTING=ON, although many projects already set it as default, which enables building the tests. Then you can domake testfor makefile generators. Or more genericallyctest --build-config <cfg>So I'm thinking if there should be an option which enables the flag and the test or if a set
runtestshould automatically add the flag. I think using thectestcommand would required addingbuild_typeto iteratable options but that would be a good idea anyway