Skip to content

update MUMmer easyblock to use apply_regex_substitutions and copy_file functions#2185

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:20200924144444_new_pr_auzwPPeQxQ
Sep 27, 2020
Merged

update MUMmer easyblock to use apply_regex_substitutions and copy_file functions#2185
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:20200924144444_new_pr_auzwPPeQxQ

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 24, 2020

(created using eb --new-pr)
testing with all existing MUMmer easyconfigs + easybuilders/easybuild-easyconfigs#11350 and easybuilders/easybuild-easyconfigs#11349, with EasyBuild running on top of both Python 2 and Python 3

requires easybuilders/easybuild-framework#3450 when running EasyBuild on top of Python 3 for easybuilders/easybuild-easyconfigs#11349

Comment thread easybuild/easyblocks/m/mummer.py Outdated
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit a15012b into easybuilders:develop Sep 27, 2020
@boegel boegel deleted the 20200924144444_new_pr_auzwPPeQxQ branch September 27, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants