update ScaLAPACK easyblock to support installation with CMake for recent versions (>= v2.1.0)#2205
Conversation
…ent versions (>= v2.1.0)
|
Looks like a big change at first, but most of it is changing indentation, and doesn't actually affect any of the existing |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
bartoldeman
left a comment
There was a problem hiding this comment.
looks ok in general but you have some very long if/else statements now, I'd find it easier to read in separate functions.
|
|
||
| # determine interface | ||
| interface = det_interface(self.log, os.path.join(blacs, 'bin')) | ||
| if not self.use_cmake: |
There was a problem hiding this comment.
can you put this in a separate function please, it would reduce the nesting a bit.
e.g. def build_step_cmake(self): and def_build_step_make(self) or similar.
…d_libscalapack_make'
|
lgtm |
|
Test report by @migueldiascosta Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
(created using
eb --new-pr)required for
foss/2020b(easybuilders/easybuild-easyconfigs#11489)