Skip to content

only configure Python with --enable-optimizations when compiling Python with (recent) GCC compiler#2228

Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:20201111112902_new_pr_ILQnklEUBG
Nov 11, 2020
Merged

only configure Python with --enable-optimizations when compiling Python with (recent) GCC compiler#2228
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:20201111112902_new_pr_ILQnklEUBG

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 11, 2020

(created using eb --new-pr)

Several people are reporting hanging installations with older Python versions, either using Intel compilers or using an older version of GCC, so we should be a bit more careful with using --enable-optimizations when building Python...

@boegel boegel added this to the 4.3.2 milestone Nov 11, 2020
Copy link
Copy Markdown
Contributor

@terjekv terjekv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes hangs for non-GCC and older compilers. I'm a bit unsure as to why GCC 8.0 was chosen as the cutoff?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 11, 2020

Fixes hangs for non-GCC and older compilers. I'm a bit unsure as to why GCC 8.0 was chosen as the cutoff?

Because that's more or less when we started building Python with GCCcore...

@boegel boegel requested a review from bartoldeman November 11, 2020 19:21
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants