take into account preinstallopts and installopts in custom easyblock for NCL#2234
Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom Nov 20, 2020
Conversation
Member
|
although using (pre)installopts here makes sense since in this easyblock building is done in the install_step, I wonder if from the user/easyconfig point of view it wouldn't make more sense to use (pre)buildopts...? |
Contributor
Author
|
Possibly. On one side, you would expect it to be in the build step. On the other side, if you put it in buildopts and you see it used in the install step when you look at the logs, it's just as puzzling. |
Member
|
True, but the logs are already puzzling in that sense even without these opts, no? i.e., there should already be a log message about building being done in the install_step? not a big deal though, so let me know if you prefer to leave it as it is |
Contributor
Author
|
I would leave it as is. |
Member
|
Going in, thanks @mboisson! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for us because I need to pass CPATH for our installation of freetype in Gentoo.