Skip to content

fix CPASSERT test faults on RHEL8 for CP2K#2236

Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom
hajgato:cp2krhel8
Nov 16, 2020
Merged

fix CPASSERT test faults on RHEL8 for CP2K#2236
migueldiascosta merged 2 commits intoeasybuilders:developfrom
hajgato:cp2krhel8

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Nov 15, 2020

No description provided.

@Micket Micket added the bug fix label Nov 16, 2020
@Micket Micket added this to the 4.3.2 milestone Nov 16, 2020
@migueldiascosta
Copy link
Copy Markdown
Member

@hajgato lowering the optimisations silently for every future version of both ifort and cp2k will likely mean these will be in effect even if they are no longer necessary... probably not a big deal, but maybe at least print a message somewhere?

also, can you submit a test report with --include-easyblocks-from-pr? (and eb 4.3.1)

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

@migueldiascosta We already lowering optimization silently for quite long time, but if it is needed, I will make them verbose.
As a matter of fact those optimization lowerings do not waste too much time. The first (ri_opt) consumes about a sub-second walltime, and once per calculation), the other one (cholesky) happen multiple times, but also quite quick. As a matter of fact, cholesky decomposition took in total 0.094 second out of 83.531 second of all tests jobs using cholesky decomposition (54 tests, and those numbers with the lowered optimization level)

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

Test report by @hajgato

Overview of tested easyconfigs (in order)

  • SUCCESS CP2K-7.1-intel-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3571.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/f069fc6c7467a1ffc8eeb74a62a748a2 for a full test report.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

--------------------------------- Summary --------------------------------
Number of FAILED  tests 0
Number of WRONG   tests 8
Number of CORRECT tests 3254
Number of NEW     tests 8
Total number of   tests 3270
--------------------------------------------------------------------------
Number of memory  leaks 0
--------------------------------------------------------------------------

@migueldiascosta
Copy link
Copy Markdown
Member

regarding the optimizations, ok, not a big deal then

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

Test report by @hajgato

Overview of tested easyconfigs (in order)

  • SUCCESS CP2K-5.1-intel-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3571.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/a0d4e25452e00a7abd691c5c07aef6f6 for a full test report.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

--------------------------------- Summary --------------------------------
Number of FAILED  tests 5
Number of WRONG   tests 2
Number of CORRECT tests 2986
Number of NEW     tests 19
Total number of   tests 3012
--------------------------------------------------------------------------
Number of memory  leaks 0
--------------------------------------------------------------------------

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

Test report by @hajgato

Overview of tested easyconfigs (in order)

  • SUCCESS CP2K-6.1-intel-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3571.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/17cbfd0a938a39c8f0300c7053eec905 for a full test report.

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @hajgato!

@migueldiascosta migueldiascosta merged commit e68d962 into easybuilders:develop Nov 16, 2020
@boegel boegel changed the title CP2K fix CPASSERT test faults on RHEL8 fix CPASSERT test faults on RHEL8 for CP2K Nov 16, 2020
@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2020

--------------------------------- Summary --------------------------------
Number of FAILED  tests 0
Number of WRONG   tests 1
Number of CORRECT tests 3047
Number of NEW     tests 19
Total number of   tests 3067
--------------------------------------------------------------------------
Number of memory  leaks 0
--------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants