Skip to content

Also add -pthread to prebuildopts of cryptography#2270

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
Flamefire:20201207135844_new_pr_sPaPeAnkhT
May 24, 2021
Merged

Also add -pthread to prebuildopts of cryptography#2270
akesandgren merged 1 commit intoeasybuilders:developfrom
Flamefire:20201207135844_new_pr_sPaPeAnkhT

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@boegel boegel added this to the 4.4.0 milestone Dec 8, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2020

@Flamefire Can you clarify why this is needed, or what problem is solved with this change?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Sure: We already do this in the preinstallopts to solve the linking failure on e.g. POWER (I'm sure you remember all the discussions, so won't repeat here)

For older Pythons we don't use pip to install stuff (for likely historic reasons setup.py is the default which is IMO unfortunate) and there the build step is executed while for pip installs only the install step is executed.
Hence for the non-pip builds the preinstallopts are to late as setup.py build already needs the -pthread.

TLDR: This is the same as we do for pip install . but for setup.py build which is used by e.g. the 2018 toolchain generation.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @Flamefire!

@akesandgren akesandgren merged commit f51db91 into easybuilders:develop May 24, 2021
@Flamefire Flamefire deleted the 20201207135844_new_pr_sPaPeAnkhT branch May 25, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants