Also add -pthread to prebuildopts of cryptography#2270
Merged
akesandgren merged 1 commit intoeasybuilders:developfrom May 24, 2021
Merged
Also add -pthread to prebuildopts of cryptography#2270akesandgren merged 1 commit intoeasybuilders:developfrom
akesandgren merged 1 commit intoeasybuilders:developfrom
Conversation
Member
|
@Flamefire Can you clarify why this is needed, or what problem is solved with this change? |
Contributor
Author
|
Sure: We already do this in the preinstallopts to solve the linking failure on e.g. POWER (I'm sure you remember all the discussions, so won't repeat here) For older Pythons we don't use pip to install stuff (for likely historic reasons setup.py is the default which is IMO unfortunate) and there the build step is executed while for pip installs only the install step is executed. TLDR: This is the same as we do for |
Contributor
|
Going in, thanks @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)