Skip to content

enhance Amber easyblock to fix running of update_amber script when 'python' command is not available in OS#2282

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:20201216112349_new_pr_UZWABbDOwH
Jan 20, 2021
Merged

enhance Amber easyblock to fix running of update_amber script when 'python' command is not available in OS#2282
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:20201216112349_new_pr_UZWABbDOwH

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 16, 2020

(created using eb --new-pr)

This is required for installing Amber or AmberTools on a system where no python command is available through the OS (which is easily the case on CentOS 8, for example).

@migueldiascosta
Copy link
Copy Markdown
Member

lgtm on visible inspection but I wonder, would it be a problem to move loading the builddependencies to before the patch_step?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 18, 2020

lgtm on visible inspection but I wonder, would it be a problem to move loading the builddependencies to before the patch_step?

See easybuilders/easybuild-framework#1376

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 19, 2021

@migueldiascosta So, is this good go in?

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit eeb178d into easybuilders:develop Jan 20, 2021
@boegel boegel deleted the 20201216112349_new_pr_UZWABbDOwH branch January 20, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants