rework module-only tests to use unique software name (rather than 'foo')#2287
Merged
boegel merged 1 commit intoeasybuilders:developfrom Dec 18, 2020
Merged
Conversation
I experienced a test failure of morthur finding artefacts from Bazel easyblock This is caused by the test modules all having the same name so a) Tests are incomplete as they may simply assert things fulfilled by previous subtests b) Tests may wrongly fail as previous tests may add unexpected files/folders which are picked up by the next tests Solution: Use unique names and workaround some limitations discovered by that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I experienced a test failure of morthur finding artefacts from Bazel easyblock
This is caused by the test modules all having the same name so
a) Tests are incomplete as they may simply assert things fulfilled by
previous subtests
b) Tests may wrongly fail as previous tests may add unexpected
files/folders which are picked up by the next tests
Solution: Use unique names and workaround some limitations discovered by that