Skip to content

make builddeps a list of names in Trilinos easyblock#2301

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210104175851_new_pr_pZOBObIfUB
Jan 6, 2021
Merged

make builddeps a list of names in Trilinos easyblock#2301
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210104175851_new_pr_pZOBObIfUB

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 4, 2021 •
edited
Loading

(created using eb --new-pr)

I noticed this while testing the PETSc changes in #2299 (review)

@branfosj branfosj mentioned this pull request Jan 4, 2021
Merged
@branfosj branfosj added this to the next release (4.3.3?) milestone Jan 4, 2021
boegel
boegel approved these changes Jan 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 5, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Trilinos-12.12.1-foss-2019b-Python-3.7.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3545.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/9d34a38bed4a9268991553ad3df57d5c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 5, 2021 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/88c83b1fde64a236704ce531aa8474a0 for a full test report.

edit: failed because apparently 32GB of RAM is not enough when using make -j 8...: g++: fatal error: Killed signal terminated program cc1plus

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 5, 2021 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/725142647790992812f80152e2a2b8dd for a full test report.

edit: apparently ~32GB of RAM isn't enough even when using just 4 cores for the build...

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 5, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Trilinos-12.12.1-foss-2019b-Python-3.7.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2df91756660d5d45291a4aef922ca427 for a full test report.

@boegel boegel merged commit f43d818 into easybuilders:develop Jan 6, 2021
@branfosj branfosj deleted the 20210104175851_new_pr_pZOBObIfUB branch January 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel