prefer default value for extra options in easyblock module-only tests#2302
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jan 6, 2021
Merged
prefer default value for extra options in easyblock module-only tests#2302boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
This was referenced Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2280 for
--module-onlytests.Use the default value for mandatory extra options which have one and fallback to
fooonly if the default is not set (None,Falseor empty).This allows having extra options with a limited number of valid options and check for those. Raising an error if the provided option is not one of the allowed values.
For instance, as it is done for
queue_cmdin the relion easyblock (PR #2274 ) ateasybuild-easyblocks/easybuild/easyblocks/r/relion.py
Line 53 in 59a5077