pass down compilation flags from build environment for ESMF#2325
Merged
smoors merged 2 commits intoeasybuilders:developfrom Feb 5, 2021
Merged
pass down compilation flags from build environment for ESMF#2325smoors merged 2 commits intoeasybuilders:developfrom
smoors merged 2 commits intoeasybuilders:developfrom
Conversation
smoors
reviewed
Feb 1, 2021
This was referenced Feb 4, 2021
Contributor
Author
|
Successful tests with this PR:
|
Contributor
|
Going in, thanks @lexming! |
Contributor
Author
|
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (7 easyconfigs in total) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build of ESMF uses its own set of flags and mostly ignores the standard flags in the environment. This PR passes the flags from EB to the build of ESMF if
optarchis set intoolchainopts.Building ESMF with EB flags vastly improves the number of tests that pass (
make unit_tests):develop: Found 3478 non-exhaustive multi-processor unit tests, 285 passed and 3193 failedUpdate: after further tests, the improvements seem to boil down to having a proper
optarchESMF_F90COMPILEOPTS=-O2 -ftree-vectorize -fno-math-errno -fPICresults in 229 passed and 3249 failed unit testsESMF_F90COMPILEOPTS=-O2 -ftree-vectorize -march=native -fno-math-errno -fPICresults in 3209 passed and 269 failed unit tests