Skip to content

Disable CMake user package repository in CMakeMake generic easyblock#2351

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210227212428_new_pr_JrPKadNFCF
Feb 28, 2021
Merged

Disable CMake user package repository in CMakeMake generic easyblock#2351
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210227212428_new_pr_JrPKadNFCF

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 27, 2021 •
edited
Loading

(created using eb --new-pr)

When building with CMake the package being built can register itself in the CMake user package registry (usually found in ~/.cmake/packages/). This registry can then be used to locate these packages when building other applications with CMake (usually this is a fallback search place). This change disables the use of the user package repository as a method of locating packages.

More information on the CMake user package registry at https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#user-package-registry

@branfosj branfosj changed the title Disable CMake user package reposiory Disable CMake user package repository Feb 27, 2021
@branfosj branfosj added this to the next release (4.3.4?) milestone Feb 27, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 28, 2021

The funny part is that the paths that are remembered are the build directories:

[boegelbot@generoso ~]$ ls -lrt .cmake/packages/
total 4.0K
drwxrwxr-x. 2 boegelbot boegelbot 4.0K Aug 20  2020 Kokkos
drwxrwxr-x. 2 boegelbot boegelbot   54 Oct 16 19:36 Libssh2
drwxrwxr-x. 2 boegelbot boegelbot   46 Dec 14 19:06 glm
drwxrwxr-x. 2 boegelbot boegelbot    6 Dec 16 08:46 Eigen3
drwxrwxr-x. 2 boegelbot boegelbot   54 Dec 17 21:01 yaml-cpp
drwxrwxr-x. 2 boegelbot boegelbot   54 Jan 13 19:58 RapidJSON
drwxrwxr-x. 2 boegelbot boegelbot   86 Feb 25 17:25 superlu

[boegelbot@generoso ~]$ cat .cmake/packages/RapidJSON/6b801d5f205a655d89f80689b047405f
/tmp/boegelbot/Arrow/0.17.1/intel-2020b/easybuild_obj/src/rapidjson_ep-build

So, changing this makes sense, and shouldn't result in any breakage.

@boegel boegel merged commit b0688d5 into easybuilders:develop Feb 28, 2021
@branfosj branfosj deleted the 20210227212428_new_pr_JrPKadNFCF branch February 28, 2021 09:13
@boegel boegel changed the title Disable CMake user package repository Disable CMake user package repository in CMakeMake generic easyblock Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel