Skip to content

Make the CUDA stub libs take preference over system libs when linking#2373

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20210330113423_new_pr_AOlfMqPwHE
Apr 6, 2021
Merged

Make the CUDA stub libs take preference over system libs when linking#2373
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20210330113423_new_pr_AOlfMqPwHE

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 30, 2021 •
edited
Loading

(created using eb --new-pr)
Fixes easybuilders/easybuild-easyconfigs#12348

The alternative would be to pass the stubs path using -L to e.g. GDRCopy

@boegel boegel changed the title Make the stub libs take preference over system libs on linking Make the CUDA stub libs take preference over system libs when linking Mar 31, 2021
@boegel boegel added the bug fix label Mar 31, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Mar 31, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-10.1.105-GCC-8.2.0-2.31.1.eb
  • SUCCESS CUDA-11.1.1-GCC-10.2.0.eb
  • SUCCESS CUDA-10.2.89-GCC-8.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/aa6ddeac55b045b4bd4fe6515fa30c71 for a full test report.

boegel
boegel approved these changes Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 6, 2021

Just for completeness: Some failures that previously yielded link errors will now be runtime errors when trying to use a program linked to the stub but run on an older driver. This is a kind of feature of course, but might be surprising.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-7.0.28.eb
  • SUCCESS CUDA-8.0.44.eb
  • SUCCESS CUDA-9.0.176.eb
  • SUCCESS CUDA-10.0.130.eb
  • SUCCESS CUDA-11.1.1-iccifort-2020.4.304.eb
  • SUCCESS CUDA-11.0.2-GCC-9.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node2607.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/a3a0543d96cd4237274154d569a0a8f5 for a full test report.

@boegel boegel merged commit 45216d8 into easybuilders:develop Apr 6, 2021
@Flamefire Flamefire deleted the 20210330113423_new_pr_AOlfMqPwHE branch April 6, 2021 18:44
@bartoldeman bartoldeman mentioned this pull request Sep 16, 2021
Closed
@boegel boegel mentioned this pull request Jan 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

GDRCopy link error on ppc64le

2 participants

@Flamefire @boegel