Remove sanity check for libnpp for CUDA 5.5 compat#238
Remove sanity check for libnpp for CUDA 5.5 compat#238boegel merged 1 commit intoeasybuilders:developfrom
Conversation
CUDA 5.5 splits libnpp into three libraries: libnppc, libnppi and libnpps. This causes the sanity check for libnpp.so to fail on version 5.5.22. Simply removed this check to maintain compatibility with CUDA 5.0. It's debatable whether it's better to special-case this check by version, but given that the CUDA installer is monolithic we probably don't need this check in addition to the others. Also removed executable bit from cuda.py permissions for consistency with other EasyBlocks.
|
This is a good example of why the list of files to be sanity-checked, AFAIK, George shares the same view like me, but not the Ghent team; My stance is that, in the name of orthogonality, over time the list of files to check can expand arbitrarily, and that should not end up as spam on the easyblock (I view the easyblock as an engine fed with easyconfig fuel ;-) |
After thinking a bit, I agree. I think it would make sense to put anything which might be expected change from one release to the next in the easyconfig. |
|
@ajdecon: I agree that simply removing We have consistently defined custom sanity check paths in easyblocks because it's the correct place, in our view. Anything that is required to make a build successful should be included in the easyblock, and the easyconfig file should be kept as simple as possible (note: we could make it even more minimal, by moving homepage, description, etc. to the easyblock as well). Usually, the version-specific differences in sanity check paths are fairly minor. This policy really helps with the maintainability of easyconfigs (especially in the absence of fat easyconfigs, i.e. one easyconfig per software package). |
Remove sanity check for libnpp for CUDA 5.5 compat
CUDA 5.5 splits libnpp into three libraries: libnppc, libnppi and
libnpps. This causes the sanity check for libnpp.so to fail on version
5.5.22.
Simply removed this check to maintain compatibility with CUDA 5.0. It's
debatable whether it's better to special-case this check by version, but
given that the CUDA installer is monolithic we probably don't need this
check in addition to the others.
Also removed executable bit from cuda.py permissions for consistency
with other EasyBlocks.