Skip to content

add easyblock for Mathematica#240

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:Mathematica
Sep 9, 2013
Merged

add easyblock for Mathematica#240
boegel merged 6 commits intoeasybuilders:developfrom
boegel:Mathematica

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 9, 2013

No description provided.

Comment thread easybuild/easyblocks/m/mathematica.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exage-rated style here ;-) otherwise reviewed and good.

@boegel boegel closed this Aug 29, 2013
@boegel boegel reopened this Aug 29, 2013
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 29, 2013

Fix style remark, thanks for the review @fgeorgatos

The easyconfig PR still needs to be reviewed though, see easybuilders/easybuild-easyconfigs#394.

We haven't been able to test the Mathematica installation on our end yet because of license server woes, so I'll hold off merging this in until our installation has been actually tested...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2013

Tested installation obtained with this easyblock, works, as expected.

@fgeorgatos: Please also review the easyconfig PR (easybuilders/easybuild-easyconfigs#394) so this can be merged in.

Comment thread easybuild/easyblocks/m/mathematica.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this to default_qa_install_path or even qa_install_path;

otherwise, this PR is fine and ready for test/merge.

boegel added a commit that referenced this pull request Sep 9, 2013
add easyblock for Mathematica
@boegel boegel merged commit 20c6794 into easybuilders:develop Sep 9, 2013
@boegel boegel deleted the Mathematica branch September 9, 2013 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants