Replace hardcoded '2021.1.1' with 'self.version' in impi easyblock#2405
Merged
boegel merged 3 commits intoeasybuilders:developfrom Apr 28, 2021
Merged
Conversation
This fixes the libfabric paths, and sanity checks for impi 2021.2.0 easybuilders/easybuild-easyconfigs#12766
Contributor
Author
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
boegel
requested changes
Apr 28, 2021
…directory in impi build dir
use self.version rather than 'latest' symlink to point to correct subdirectory in impi build dir
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
boegel
approved these changes
Apr 28, 2021
Member
boegel
left a comment
There was a problem hiding this comment.
tested with existing impi easyconfigs + easybuilders/easybuild-easyconfigs#12766, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the libfabric paths, and sanity checks for
impi 2021.2.0
easybuilders/easybuild-easyconfigs#12766