Skip to content

enable sanity_pip_check by default for Python easyconfigs if pip >= 9.0 will be installed#2423

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:enable_sanity_pip_check_in_python
May 14, 2021
Merged

enable sanity_pip_check by default for Python easyconfigs if pip >= 9.0 will be installed#2423
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:enable_sanity_pip_check_in_python

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented May 12, 2021 •
edited by boegel
Loading

This detects issues with e.g. missing dependencies early and ensures that our base Python installations are clean/correct.

@Flamefire
Enable sanity_pip_check by default for Python ECs if pip >= 9.0 will …
ff631be 
…be installed

This detects issues with e.g. missing dependencies early and ensures
that our base Python installations are clean/correct.
@Flamefire Flamefire mentioned this pull request May 12, 2021
Merged
@boegel boegel added this to the next release (4.4.0) milestone May 12, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

I'll try and get back to this once #2388 is merged.

Making sure there's no fallout for the easyconfigs in the central easybuilders/easybuild-easyconfigs repo requires rebuilding a large bunch of Python easyconfigs (significantly more than needed for #2388), which is why this was fleshed out in a separate PR...

@boegel
Copy link
Copy Markdown
Member

boegel commented May 14, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.10-GCC-4.9.3-2.25-bare.eb
  • SUCCESS Python-2.7.10-GNU-4.9.3-2.25-bare.eb
  • SUCCESS Python-2.7.11-foss-2016a.eb
  • SUCCESS Python-2.7.11-GCC-4.9.3-2.25-bare.eb
  • SUCCESS Python-2.7.11-intel-2016.02-GCC-4.9.eb
  • SUCCESS Python-2.7.11-intel-2016a.eb
  • SUCCESS Python-2.7.12-GCC-5.4.0-2.26-bare.eb
  • SUCCESS Python-2.7.12-GCCcore-4.9.3-bare.eb
  • SUCCESS Python-2.7.13-GCCcore-6.3.0-bare.eb
  • SUCCESS Python-2.7.14-foss-2017b.eb
  • SUCCESS Python-2.7.14-foss-2018a.eb
  • SUCCESS Python-2.7.14-fosscuda-2017b.eb
  • SUCCESS Python-2.7.14-fosscuda-2018a.eb
  • SUCCESS Python-2.7.14-GCCcore-6.4.0-bare.eb
  • SUCCESS Python-2.7.15-foss-2018b.eb
  • SUCCESS Python-2.7.15-fosscuda-2018b.eb
  • SUCCESS Python-2.7.15-GCCcore-7.2.0-bare.eb
  • SUCCESS Python-2.7.15-GCCcore-7.3.0-bare.eb
  • SUCCESS Python-2.7.15-GCCcore-8.2.0.eb
  • SUCCESS Python-2.7.15-intel-2018b.eb
  • SUCCESS Python-2.7.15-iomkl-2018b.eb
  • SUCCESS Python-2.7.16-GCCcore-8.3.0.eb
  • SUCCESS Python-2.7.18-GCCcore-10.2.0.eb
  • SUCCESS Python-2.7.18-GCCcore-9.3.0.eb
  • SUCCESS Python-2.7.9-GCC-4.8.4-bare.eb
  • SUCCESS Python-2.7.9-GCC-4.9.2-bare.eb
  • SUCCESS Python-3.5.1-foss-2016a.eb
  • SUCCESS Python-3.6.2-foss-2017b.eb
  • SUCCESS Python-3.6.4-foss-2017a.eb
  • SUCCESS Python-3.6.4-foss-2018a.eb
  • SUCCESS Python-3.6.4-fosscuda-2018a.eb
  • SUCCESS Python-3.6.4-golf-2018a.eb
  • SUCCESS Python-3.6.4-iomkl-2018.02.eb
  • SUCCESS Python-3.6.6-foss-2018b.eb
  • SUCCESS Python-3.6.6-fosscuda-2018b.eb
  • SUCCESS Python-3.6.6-intel-2018b.eb
  • SUCCESS Python-3.6.6-iomkl-2018b.eb
  • SUCCESS Python-3.7.0-foss-2018b.eb
  • SUCCESS Python-3.7.0-intel-2018b.eb
  • SUCCESS Python-3.7.0-iomkl-2018b.eb
  • SUCCESS Python-3.7.2-GCCcore-8.2.0.eb
  • SUCCESS Python-3.7.4-GCCcore-8.3.0.eb
  • SUCCESS Python-3.8.2-GCCcore-9.3.0.eb
  • SUCCESS Python-3.8.6-GCCcore-10.2.0.eb

Build succeeded for 44 out of 44 (44 easyconfigs in total)
node2669.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/64cde5cd1c591aae2cfddd6c208d9260 for a full test report.

boegel
boegel approved these changes May 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests show that there's no reason not to do this, since there's no fallout for the Python easyconfigs we have centrally, going back pretty far.

Thanks @Flamefire!

@boegel boegel changed the title Enable sanity_pip_check by default for Python ECs if pip >= 9.0 will be installed enable sanity_pip_check by default for Python easyconfigs if pip >= 9.0 will be installed May 14, 2021
@boegel boegel merged commit e79962a into easybuilders:develop May 14, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented May 14, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.10-GCC-4.9.3-2.25-bare.eb
  • SUCCESS Python-2.7.10-GNU-4.9.3-2.25-bare.eb
  • SUCCESS Python-2.7.11-foss-2016a.eb
  • SUCCESS Python-2.7.11-GCC-4.9.3-2.25-bare.eb
  • SUCCESS Python-2.7.11-intel-2016.02-GCC-4.9.eb
  • SUCCESS Python-2.7.11-intel-2016a.eb
  • SUCCESS Python-2.7.12-GCC-5.4.0-2.26-bare.eb
  • SUCCESS Python-2.7.12-GCCcore-4.9.3-bare.eb
  • SUCCESS Python-2.7.13-GCCcore-6.3.0-bare.eb
  • SUCCESS Python-2.7.14-foss-2017b.eb
  • SUCCESS Python-2.7.14-foss-2018a.eb
  • SUCCESS Python-2.7.14-fosscuda-2017b.eb
  • SUCCESS Python-2.7.14-fosscuda-2018a.eb
  • SUCCESS Python-2.7.14-GCCcore-6.4.0-bare.eb
  • SUCCESS Python-2.7.15-foss-2018b.eb
  • SUCCESS Python-2.7.15-fosscuda-2018b.eb
  • SUCCESS Python-2.7.15-GCCcore-7.2.0-bare.eb
  • SUCCESS Python-2.7.15-GCCcore-7.3.0-bare.eb
  • SUCCESS Python-2.7.15-GCCcore-8.2.0.eb
  • SUCCESS Python-2.7.15-intel-2018b.eb
  • SUCCESS Python-2.7.15-iomkl-2018b.eb
  • SUCCESS Python-2.7.16-GCCcore-8.3.0.eb
  • SUCCESS Python-2.7.18-GCCcore-10.2.0.eb
  • SUCCESS Python-2.7.18-GCCcore-9.3.0.eb
  • SUCCESS Python-2.7.9-GCC-4.8.4-bare.eb
  • SUCCESS Python-2.7.9-GCC-4.9.2-bare.eb
  • SUCCESS Python-3.5.1-foss-2016a.eb
  • SUCCESS Python-3.6.2-foss-2017b.eb
  • SUCCESS Python-3.6.4-foss-2017a.eb
  • SUCCESS Python-3.6.4-foss-2018a.eb
  • SUCCESS Python-3.6.4-fosscuda-2018a.eb
  • SUCCESS Python-3.6.4-golf-2018a.eb
  • SUCCESS Python-3.6.4-iomkl-2018.02.eb
  • SUCCESS Python-3.6.6-foss-2018b.eb
  • SUCCESS Python-3.6.6-fosscuda-2018b.eb
  • SUCCESS Python-3.6.6-intel-2018b.eb
  • SUCCESS Python-3.6.6-iomkl-2018b.eb
  • SUCCESS Python-3.7.0-foss-2018b.eb
  • SUCCESS Python-3.7.0-intel-2018b.eb
  • SUCCESS Python-3.7.0-iomkl-2018b.eb
  • SUCCESS Python-3.7.2-GCCcore-8.2.0.eb
  • SUCCESS Python-3.7.4-GCCcore-8.3.0.eb
  • SUCCESS Python-3.8.2-GCCcore-9.3.0.eb
  • SUCCESS Python-3.8.6-GCCcore-10.2.0.eb

Build succeeded for 44 out of 44 (44 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c2bba202e868d394526c691ab2feceb8 for a full test report.

@Flamefire Flamefire deleted the enable_sanity_pip_check_in_python branch May 15, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel